4396 packs 1 add custom request units at organizational level #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Eccatoe -- Thanks for this! I'm doing some manual testing.
|
|
|
|
|
cielf
requested changes
Jun 1, 2024
There was a problem hiding this comment.
Hey @Eccatoe - Good start! I was assuming this was ready for review (because it's Open rather than Draft). If thats not the case, please just treat the comments as a check-list for finishing it up.
This is a first functional review, rather than a code review per se. If you have any problem with recreating, please ping me on slack and I can walk you through it.
|
@cielf Sorry, I should have tagged this as a Draft, it is certainly a WIP. Thank you for the feedback, we will work on those issues! |
Eccatoe
commented
Jun 1, 2024
| @@ -15,7 +15,8 @@ def edit | |||
| def update | |||
| @organization = current_organization | |||
|
|
|||
| if OrganizationUpdateService.update(@organization, organization_params) | |||
| @units = Unit.where(params.dig(:request_units_attributes)&.dig(:name)) | |||
There was a problem hiding this comment.
TODO deleting all units - needs fix
…om-request-units-at-organizational-level Conflicts: app/controllers/organizations_controller.rb
…anizational-level
|
This PR was continued over at #4432! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4396